Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3917

Merged
merged 2 commits into from Apr 14, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Apr 14, 2020

No description provided.

Glenn Watson and others added 2 commits Apr 14, 2020
On some (primarily older, integrated) drivers, we see significant
time in CPU stalls during updates to the vertex data textures.

As a short term fix, this patch creates an array of vertex data
textures, and rotates which set of them are in use each frame.

There are better long-term options (such as porting the GPU cache
scatter method, or perhaps using UBO/SSBOs here), but this is a
simple workaround for now.

Differential Revision: https://phabricator.services.mozilla.com/D70775

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/b396f2b243fd9433e6038afdf03c905c1e0b3055
Previously, the prim origin needed to be stored in the prim
instance, to avoid picture cache invalidations. With support
for external scroll offset, this is no longer necessary.

This simplifies some of the code paths, and reduces the size
of primitive instances.

Differential Revision: https://phabricator.services.mozilla.com/D70740

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/1f65f78fb36707cd936882f4d363f7c5f8a3314d
@moz-gfx
Copy link
Author

moz-gfx commented Apr 14, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

📌 Commit 09522cd has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

Testing commit 09522cd with merge 02f5fa5...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 14, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing 02f5fa5 to master...

@bors-servo bors-servo merged commit 02f5fa5 into servo:master Apr 14, 2020
3 checks passed
3 checks passed
Community-TC (pull_request) TaskGroup: success
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.