Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3918
Merged
+16
−10
Conversation
These assertions don't hold in some perfectly legitimate cases, such as when items have both top and bottom sticky behaviours. The actual behaviour still seems ok, so let's just drop the assertions. Differential Revision: https://phabricator.services.mozilla.com/D70459 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/259c147efa83074869ce93c3053b4ecbd80863d6
…y ranges. r=kvark The WR code that computed the sticky_offset didn't properly combine the offsets from the top- and bottom- sticky calculations if an item had both. This patch fixes the calculation, which makes the remaining test failure (in the configuration without any dynamic toolbar) pass. Depends on D70679 Differential Revision: https://phabricator.services.mozilla.com/D70680 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/2c065921de099b97532775e1aca5973edd5512b2
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 14, 2020
No description provided.