Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3918

Merged
merged 2 commits into from Apr 15, 2020
Merged

Sync changes from mozilla-central gfx/wr #3918

merged 2 commits into from Apr 15, 2020

Commits on Apr 14, 2020

  1. Bug 1628484 - Remove assertions that don't always hold. r=kvark 

    These assertions don't hold in some perfectly legitimate cases, such as when
items have both top and bottom sticky behaviours. The actual behaviour still
seems ok, so let's just drop the assertions.

Differential Revision: https://phabricator.services.mozilla.com/D70459

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/259c147efa83074869ce93c3053b4ecbd80863d6
    @staktrace @moz-gfx
    staktrace authored and moz-gfx committed Apr 14, 2020
    e097b8a

  2. Bug 1629521 - Fix WR handling of items with both top and bottom stick… 

    …y ranges. r=kvark

The WR code that computed the sticky_offset didn't properly combine the offsets
from the top- and bottom- sticky calculations if an item had both. This patch
fixes the calculation, which makes the remaining test failure (in the
configuration without any dynamic toolbar) pass.

Depends on D70679

Differential Revision: https://phabricator.services.mozilla.com/D70680

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/2c065921de099b97532775e1aca5973edd5512b2
    @staktrace @moz-gfx
    staktrace authored and moz-gfx committed Apr 14, 2020
    Loading status checks…
    686307b
You can’t perform that action at this time.