Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3923
Merged
Conversation
…ty updates. r=kvark The FrameTexturesUpdated event is intended to be issued when any necessary texture cache updates have been completed for the current frame. Originally we would simply check if the pending_texture_updates vector in Renderer is empty. However the updates themselves could be nops, and not trigger a timely frame render to occur, causing the notifications to be delayed indefinitely. Now we track if there are actually any pending specifically texture cache updates and only defer the notification if true. A consequence of deferring the notification indefinitely was revealed when animating images just outside the current view. We would not release the buffers for recycling even though we had no reason to hold onto them. This could cause the image decoder to allocate new buffers while the old buffers would not get released. It was not a true memory leak because as soon as a frame is rendered, it would release all of the old buffers, but it could easily cause a out of memory crash to occur if the user was not interacting with the browser while in this state. Differential Revision: https://phabricator.services.mozilla.com/D70770 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/3e0fdd643f2e134f6c278a2d3b17db172d2efa18
…r=jimb This provides an implementation of linear filtering via the linear_blit routine. That required factoring out textureLinear helper functions and reusing them to do the actual filtering of the source texture. Some collateral cleanups involved changing IntRect to use a start/end format instead of origin/size, cleaner ways of getting offset texture sampler pointers, and fixing clamping of linear filter coordinates. Differential Revision: https://phabricator.services.mozilla.com/D70968 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/57e35a75329f24c58300c5c9265002e0bc3c2739
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 17, 2020
No description provided.