Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3926
Merged
+40
−10
Conversation
added 4 commits
Apr 21, 2020
…DONTBUILD r=kvark Differential Revision: https://phabricator.services.mozilla.com/D71367 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/8c9a6a498a944f34ac736deeb76d2c80ab2a2518
…abled. r=lsalzman When the `software` feature is enabled, a clause gets added to two `match` statements, causing Rust to complain that another `match` clause is unreachable. This patch makes the other match clause conditional on the absence of the `software` feature. Differential Revision: https://phabricator.services.mozilla.com/D71443 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/0ff89c708ad7488fd4f156603be42c3009952ee9
…=lsalzman Provide an explicit copy constructor for the GCC `VectorType` polyfill. Since `VectorType` has an assignment operator, GCC is uncomfortable faking a copy constructor, so we have to provide one. Make `VectorType` default constructor actually initialize the elements. When we have a GLSL `if` whose condition varies from fragment to fragment, and whose alternatives either assign to a variable or discard the fragment, we compile the assignment to an `if_then_else` call that preserves the old elements for fragments not taking the assignment's path. But if this is the initializing assignment, the 'old value' operand to that `if_then_else` is uninitialized. We could make the translator smarter about this, and have it not use predicated assignment in such cases, but this fix is fine for now. Make `VectorType::wrap` take its argument by const reference, to avoid weird ABI 'notes'. Differential Revision: https://phabricator.services.mozilla.com/D71444 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ef53eeea860213842aa1e23f611f523b5bd9679b
Add `UNUSED` marker to `gl.cc` function arguments. Add GCC pragmas to ignore `-Wunused-parameter` and `-Wunused-but-set-variable` warnings in the generated shaders. Since these are generated from GLSL, it is hard to avoid the warnings by changing the code itself. Avoid uninitialized values in `vec4::operator[]`. Differential Revision: https://phabricator.services.mozilla.com/D71445 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/4cd8258082d7d03ac0450b8272d4ae39ad1dbd04
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 21, 2020
No description provided.