Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3928
Conversation
… webrender. r=jrmuizel Update Cargo.lock files and vendor sources in to tree. Differential Revision: https://phabricator.services.mozilla.com/D70030 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/5ab3301774791510be236f43473ae18a3210ffaa
Move more shader parsing code to webrender_build, so it can be used both at runtime and build time. At build time optimize a set of shaders and feature flag combinations, using glslopt. Some features are skipped because they are not supported by the gl version, because the optimizer does not support them, or because webrender does not need them currently. Use build-parallel to ensure the optimization is performed in parallel using the make jobserver. Write the optimized shader source to a hashmap to be used at runtime, in addition to the unoptimized source. Differential Revision: https://phabricator.services.mozilla.com/D70032 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/416526bbe3dac4ac5c8d299a086f252438c06020
Add a gecko pref "gfx.webrender.use-optimized-shaders". If enabled, then when attempting to compile a webrender shader first look for the optimized source. If the optimized source is not present, emit a warning and fall back to the unoptimized source. Use the optimized source by default in wrench, and add the flag "--use-unoptimized-shaders" to override this. Differential Revision: https://phabricator.services.mozilla.com/D70033 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/37870a77af5371a9a6d80cf7814e4bc28b037533
Differential Revision: https://phabricator.services.mozilla.com/D70034 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b4ebfaf0e6f3ed856786b6e145741e273066b225
…=nical Differential Revision: https://phabricator.services.mozilla.com/D71703 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b73e159aeed93cc567c3c9fba85308dee14144e6
|
@bors-servo r=auto |
|
|
Sync changes from mozilla-central gfx/wr
|
|
It's no longer required, since we inflate the picture and surface rects directly. Differential Revision: https://phabricator.services.mozilla.com/D71712 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/2c50d92db0137153443a782052a708c84adc112a
… on default-subregion.svg and mix-blend-mode-and-filter.svg CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/84855eefe4c47deb80d3a9693f5aa7c9f5b9f03c
|
@bors-servo r=auto |
|
|
|
|
Looks like we need to update the docker image to include clang to make @jamienicol 's glsl thing work. I'm trying to do that |
|
Thanks @kats! For future reference, what did I break here and how do I avoid breaking it in the future? |
|
So the webrender tests run in two configurations, since WebRender is used both as part of Firefox and as a standalone project. In Firefox CI they are run via the config in In terms of avoiding it in the future, I guess the way to know would have been to clone this github repo, copy over your changes to a fork, and make a PR to let the run (Aside: in theory you shouldn't need to create a PR, and should be able to run the taskcluster-github integration on your own fork directly but the documentation for that is missing, see bug 1619286). |
Differential Revision: https://phabricator.services.mozilla.com/D71874 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/9b54ceab63709d48b6efdbc67ad275787b46e63e
|
@bors-servo r=auto |
|
|
|
Cool, thanks. I'll be aware of the standalone webrender taskcluster configuration in the unlikely event I make a similar change again :) (Just realised I tagged the wrong username in my last reply, sorry other kats!) |
…th API. r=gw Now that the capture code is gone, we don't use these serde implementations. They get in the way of changing the way transactions are represented so I'd like to remove a bunch of them for now. Differential Revision: https://phabricator.services.mozilla.com/D71604 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a307cb281ea1ac328796b23650d010d53084205a
The code is untested, and mostly obsoleted by (multi) frame captures. Also it gets in the way of some other changes I need to make. Differential Revision: https://phabricator.services.mozilla.com/D71372 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/4ab8d5caf58fe9d7e2e0ef5b3d6ff94c4e395cff
…the api crate. r=gw This is a small preliminary refactoring that will be needed to let the api talk to the scene builder thread. Differential Revision: https://phabricator.services.mozilla.com/D71325 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/d3387bfa2b029f4bbc636bc521fe789de4085606
|
@bors-servo r=auto |
|
|
In bug 1589669 we ensured that webrender snaps the asynchronous scroll offset correctly. Prior to that, the fractional offsets of picture cache tiles were changing every frame, leading to excessive picture cache invalidation. Since then, however, we have landed bug 1609002, which made it so that asynchronous scrolling is split in to the scroll offset and the visual viewport transform. The visual viewport transform is sent to webrender as an animated transform property, and since this was not being snapped it regressed the picture caching invalidation fix. This change ensures that offset is snapped correctly. Differential Revision: https://phabricator.services.mozilla.com/D71920 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/1ba2c8fbef070eac296d96460b2e3c7c50479fa9
…ly. r=jrmuizel The list of pre-optimized shaders was being generated in a non-deterministic order, causing large build time regressions. This sort the list of shaders before writing them to the shaders.rs file. Differential Revision: https://phabricator.services.mozilla.com/D71905 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/19e4643b08381f59a829506cea2ceb5b986d64a5
…CI on Github to include clang. r=jnicol Differential Revision: https://phabricator.services.mozilla.com/D71965 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ad803728f512dd9b9809257290395ac7497421c1
|
@bors-servo r=auto |
|
|
|
@bors-servo r- |
|
@bors-servo r=auto |
|
|
|
|
moz-gfx commentedApr 21, 2020
No description provided.