Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3931

Merged
merged 3 commits into from Apr 24, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Apr 23, 2020

No description provided.

nical and others added 3 commits Apr 23, 2020
…e scene builder thread. r=gw

The goal is to move this code out of the render backend to avoid requiring the messages to transit through this thread. Other similar changes are in progress.

Differential Revision: https://phabricator.services.mozilla.com/D71781

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/7675477d0507096eaaaeb916ed8b5ec44c5b6db1
…r=gw

DocumentView has a mix of members that affect scene building and memebers that change frame to frame. These need to be updated at different rates and more importantly follow the respective flow of scene and frame transactions, which wasn't done properly before this change.

Depends on D71781

Differential Revision: https://phabricator.services.mozilla.com/D71927

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/4933e4b66edb70f5b8f682abc6025e9f50f14e4b
…o optimize. r=jrmuizel

A previous patch attempted to optimize only GL or GLES shaders,
depending on the target platform. However, it was trying to detect the
platform by using `cfg!(target_os = {})`, but as this is in a
build script that actually detects the host platform instead. This
resulted in the wrong version of shaders being optimized, and
therefore falling back to unoptimized shaders at runtime.

This fix uses `env::var("CARGO_CFG_TARGET_OS")` instead, which works
correctly in build scripts.

Differential Revision: https://phabricator.services.mozilla.com/D72127

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/17a4926b6c65598c268f620c9c836f1798670c78
@moz-gfx
Copy link
Author

moz-gfx commented Apr 23, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2020

📌 Commit 1ba07e5 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 23, 2020

Testing commit 1ba07e5 with merge 994d4be...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 24, 2020

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: auto
Pushing 994d4be to master...

@bors-servo bors-servo merged commit 994d4be into servo:master Apr 24, 2020
2 of 3 checks passed
2 of 3 checks passed
Community-TC (pull_request) TaskGroup: Pending (for pull_request.opened)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.