Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3935
Merged
Conversation
…ions. r=kats,Bert They aren't used, so can easily be removed as the first part of this seried of patches. If this functionality is ever required, it can be handled by the caller defining complex clip nodes explicitly. Differential Revision: https://phabricator.services.mozilla.com/D72261 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/d60fcfdde68b76eca83080ea047f09a17dc65395
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 27, 2020
Sync changes from mozilla-central gfx/wr
|
|
|
@bors-servo r- |
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 27, 2020
Sync changes from mozilla-central gfx/wr
This allows defining rectangle clips directly, rather than via the generic clip region methods. This patch doesn't make use of it in Gecko yet, but it will do once we add the remaining rounded rect API. Differential Revision: https://phabricator.services.mozilla.com/D72268 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/eed6e488f1e431850c67e960e7c8cd30ff5fa1d3
This adds the last remaining explicit API for defining clips of a specific type, and ports wrench and examples to use them. Differential Revision: https://phabricator.services.mozilla.com/D72284 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/4e6f16db2484d405fa34552d2221bfb3ec0b0aa2
|
@bors-servo r=auto |
|
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 27, 2020
Sync changes from mozilla-central gfx/wr
|
|
…he frame being a no-op. r=gw The RenderBackend can be sent an `invalidate_rendered_frame` flag to indicate that the current rendered frame is invalid. This is useful when the platform requires a render, eg when starting or resuming the app on Android. Upon receiving this flag, the render backend will set a variable `doc.rendered_frame_is_valid = false`. Later on it will decide to skip rendering only if this variable is true, so by setting the invalidate flag we should be able to ensure the next render will occur. However, the RenderBackend also tries to skip renders which it determines are not required. Currently it does this by setting `doc.rendered_frame_is_valid = true` if it decides the frame is a no-op. This overwrites the previous value set by the `invalidate_rendered_frame` flag, meaning webrender skips renderering even though the platform has requested it. This was resulting in the GVE app showing a black screen on startup, and Fenix temporarily showing a black screen whilst opening a new tab, because despite WebRenderBridgeParent requesting an invalidation immediately on startup, webrender ignored that request until it decided it actually had content to paint. To fix this, the logic should be flipped. The value of `doc.rendered_frame_is_valid` must be remembered across document updates rather than defaulting to false. And instead of setting it true if webrender thinks the frame is a no-op, we must set it false if webrender thinks the frame is *not* a no-op. Differential Revision: https://phabricator.services.mozilla.com/D72600 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/2760b8a14f17ac39b2b6cc1ac2d63f2f1d05bb77
Differential Revision: https://phabricator.services.mozilla.com/D72748 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/67963e21130f2bc4b8d074e765eda5c7ded25622
…r=jdm [import_pr] From #3936 Differential Revision: https://phabricator.services.mozilla.com/D72749 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ed056d11c2b330854c133e9273e6c54fcce52e26
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedApr 27, 2020
No description provided.