Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3940

Merged
merged 16 commits into from May 6, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Apr 29, 2020

No description provided.

@moz-gfx
Copy link
Author

moz-gfx commented Apr 29, 2020

@bors-servo r=auto

@moz-gfx
Copy link
Author

moz-gfx commented Apr 30, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

📌 Commit 88a4433 has been approved by auto

@staktrace
Copy link
Contributor

staktrace commented Apr 30, 2020

@staktrace
Copy link
Contributor

staktrace commented Apr 30, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

📌 Commit ff0052a has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

Testing commit ff0052a with merge 2febc86...

bors-servo added a commit that referenced this pull request Apr 30, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented Apr 30, 2020

💔 Test failed - status-appveyor

@staktrace
Copy link
Contributor

staktrace commented Apr 30, 2020

The appveyor build time "for our plan" seems to have gone from 100 minutes to 60 minutes?

jamienicol and others added 7 commits May 1, 2020
…. r=jrmuizel

Based on ideas discussed to solve bug 1633912, this patch implements allowing each shader to switch between no-perspective and perspective on per-primitive based on whether or not the primitive's W coordinates all match. This should be a sufficient stop-gap for now to unblock testing and development. Performance and memory usage costs of this approach will need to be evaluated before we decide whether to keep it long term.

Differential Revision: https://phabricator.services.mozilla.com/D73298

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/2d29da387d9e6eb8051481838baed37d9fc57b5a
…=jrmuizel

Currently SWGL stores separate copies of flat interpolants, uniforms, and samplers for vertex shaders and fragment shaders. We can just make the fragment shader inherit from the vertex shader, which allows us to only have to store one copy of these, and also obviates the need to store them out and read them back to transition from vertex shader to fragment shader per-primitive. This will help offset the performance cost of perspective checking in bug 1634447.

Differential Revision: https://phabricator.services.mozilla.com/D73299

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/6beeb0d6d31a65085d138ca5f784620dea8c6ecc
@moz-gfx
Copy link
Author

moz-gfx commented May 1, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2020

📌 Commit e1725b9 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2020

Testing commit e1725b9 with merge 48db159...

bors-servo added a commit that referenced this pull request May 1, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented May 1, 2020

💔 Test failed - status-appveyor

bpeersmoz and others added 2 commits May 5, 2020
… screen r=gw

Part 1 - support RGB external surfaces for promotion to compositor
surfaces; add new shader permutations to handle all buffer kinds.
Set the promotion flag when the pixel format has no alpha, or when the
texture provider can guarantee all-solid alpha values.

Differential Revision: https://phabricator.services.mozilla.com/D71120

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/bacce3517d5ee08fa12f26de62e6c2493d44615c
Previously, WR would internally mark a parent stacking context
as requiring isolation when a stacking context with mix-blend-mode
was encountered.

However, this adds significant complexity to scene building in
WR, meaning that several decisions related to stacking context
redundancy, clip chain roots must be delayed until the stacking
context is popped.

By requiring the display list to annotate blend containers (Gecko
already has all this information available), we will be able to
simplify this scene building logic, which will unblock some
ongoing improvements to how clips are handled.

The patch introduces stacking context flags, and ports the existing
is_backdrop_root bool to be part of these flags. It also removes
an unused old field, cache_tiles.

Differential Revision: https://phabricator.services.mozilla.com/D73597

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/a70b26f401c211af63a873d64a9d64dba8e075c1
@moz-gfx
Copy link
Author

moz-gfx commented May 5, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

📌 Commit bc19ec2 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

Testing commit bc19ec2 with merge 3edeb22...

bors-servo added a commit that referenced this pull request May 5, 2020
Sync changes from mozilla-central gfx/wr
@bors-servo
Copy link
Contributor

bors-servo commented May 5, 2020

💔 Test failed - status-appveyor

@staktrace
Copy link
Contributor

staktrace commented May 5, 2020

@jdm do you know if the appveyor plan for the servo account changed? i thought the build time allowed was 100 minutes but now it seems to be 60 minutes, causing failures.

@jdm
Copy link
Member

jdm commented May 5, 2020

Yes, there was a discussion in #gfx-firefox about how we reverted to the free plan and Appveyor should be turned off on this repo if that caused any issues.

@staktrace
Copy link
Contributor

staktrace commented May 5, 2020

Ok, thanks. I'll remove the appveyor.yml file then.

…=Bert

The spatial node index and clip chain id are no longer directly
related concepts, since they now exist in different representations
(the spatial tree and clip store).

Removing the grouping of these during scene building simplifies
some work in progress to refactor how WR internally represents
clips, in order to allow future optimization work.

Differential Revision: https://phabricator.services.mozilla.com/D73187

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/43b402485bd1afa62bf5f13ab75d12d6a20e05e9
@moz-gfx
Copy link
Author

moz-gfx commented May 6, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

📌 Commit 28043d4 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

Testing commit 28043d4 with merge 1981954...

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2020

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing 1981954 to master...

@bors-servo bors-servo merged commit 1981954 into servo:master May 6, 2020
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.