Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3949
Merged
Conversation
…ying synthetic-bold, to avoid unreliable subpixel positioning. r=jrmuizel If we pass an array of glyph IDs (all the same) and positions (with 1-pixel offsets) to CTFontDrawGlyphs to generate the rasterized image for a synthetic-bold glyph, it's possible that -- depending on the fractional-pixel x position and the character coverage of the font -- it may misposition the rendering of one (or more?) of the copies of the glyph bitmap within the context, such that we lose the intended double-struck/offset effect. The problem doesn't occur if we render the exact same glyphs and positions to the context using individual single-glyph calls to CTFontDrawGlyphs. Differential Revision: https://phabricator.services.mozilla.com/D74918 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/fd7f3a8bba92b52058f3a3d8f3a86632dc993d6b
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedMay 13, 2020
No description provided.