Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3958
Merged
+152
−23
Conversation
…r=mstange Differential Revision: https://phabricator.services.mozilla.com/D75119 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b57a096b5ba4955abe131079820801457ee397af
Differential Revision: https://phabricator.services.mozilla.com/D75305 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/67745f2dd84827d30f654d75766351ff788f5114
Previously, WR would attempt to detect at the start of frame building if the spatial node of any picture cache contained a non-axis-aligned transform, and disable picture caching in that edge case. However, picture caching can't (currently) be disabled when the native compositor is active. In this mode, picture caching was force enabled, causing an assertion failure due to unexpected coordinate systems when updating pictures. This patch changes the way the detection of scroll root logic works such that we don't consider any scroll frame inside a reference frame to be a valid scroll root for picture caching purposes. Thus it's not possible to create a picture cache where the reference spatial node has a non-axis-aligned transform. Differential Revision: https://phabricator.services.mozilla.com/D75890 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b04340bad99d70638efda2e7d528e89df77e47c4
…r=Bert,jrmuizel Some pages created nesting levels of scroll roots where the outer scroll frames are redundant (the scrollable size is zero if the content rect is the same as the frame rect). In these cases, it is of no benefit to select these as a scroll root for picture cache tiles. Differential Revision: https://phabricator.services.mozilla.com/D75451 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a2078244558da928f2df9943595ab8ad03485c29
…E_2D. r=gw The android emulator appears to have a bug in its OpenGL implementation where it gets confused about whether a texture is bound to GL_TEXTURE_EXTERNAL_OES or GL_TEXTURE_2D. This was causing spurious errors when attempting to use a regular 2D texture, due to the fact that an external texture had previously been bound. Work around this by explicitly unbinding from GL_TEXTURE_EXTERNAL_OES immediately before binding to GL_TEXTURE_2D. Differential Revision: https://phabricator.services.mozilla.com/D76318 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b9d97c8a708eb0c8b567d352833884c3103b0afc
…n slack. [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ff097baf211dee2eba829838180cfdc3082b50ef
…r=Bert,jrmuizel Some pages created nesting levels of scroll roots where the outer scroll frames are redundant (the scrollable size is zero if the content rect is the same as the frame rect). In these cases, it is of no benefit to select these as a scroll root for picture cache tiles. Differential Revision: https://phabricator.services.mozilla.com/D75451 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/3afdf3a5bec4902b80f5e67d93ca9f7f9f12edbd
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedMay 22, 2020
No description provided.