Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3959
Merged
Conversation
and others
added 3 commits
May 22, 2020
…re invalidated, and added it as an event marker to the profiler. r=jrmuizel,gw Differential Revision: https://phabricator.services.mozilla.com/D76389 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/dcf166da7a8bad96946df5d46b9f4beff8ce46f9
…nsactionMsg structs. r=gw One of the last steps towards letting the api send scene building requests directly. I'll clean up the names after everything is in place. Differential Revision: https://phabricator.services.mozilla.com/D74054 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/8990e5bd99608f2b45c570ea00f93c45eeec7ccf
This patch separates SceneBuilderRequest into two enums: One we'll be able to send from the api, and containing types that shouldn't move to the webrender_api crate. For example LoadScene depends on the Scene struct and at this point a quarter of webrender's types would need to move to webrender_api. This solution is a bit iffy but I'm not sure how to better do this. If we don't need strict ordering, moving to crossbeam's queue which support select would let us at least avoid sending dummy BackendMessage to instruct the scene builder thread to look into the other queue. This patch should not change the current behavior except for one (important) detail: all messages that use BackendSceneBuilderMessage have to go through the low priority scene queue instead of the high priority one. This affects the capture stuff, I think that it's still correct but I'm not familiar enough with it to be sure. Differential Revision: https://phabricator.services.mozilla.com/D72717 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/1981a4af9b8ef9382cc47ef3c24e83530591540e
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedMay 22, 2020
No description provided.