Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3968

Merged
merged 4 commits into from May 28, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented May 28, 2020

No description provided.

Lee Salzman and others added 4 commits May 28, 2020
… be pushed as an image r=jrmuizel

If |nsDisplayItem::CreateWebRenderCommands()| returns false, the items that have been pushed to |DisplayListBuilder::pending_chunk| need to be cleared, because the item will be pushed as an image instead. This happens, for example, when nsDisplayText encounters unsupported features.

Differential Revision: https://phabricator.services.mozilla.com/D77095

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/d9f5353bcddc0f4b879695e8965911f9978e189d
…=aosmond

Bug 1620014 attempted to fix an issue where an animated visual
viewport offset (eg due to scrolling while being zoomed in) was
causing the fractional offset of a descendant scroll frame's content
transform to change, causing too much picture cache invalidation.

It did so by snapping the coordinate-system-relative offset when using
it to calculate the content_transform. This value of course includes
the animated visual viewport offset (as the axis-aligned zoom
transform cannot reset the coordinate system). However, it also
includes non-animated offsets, which were now being incorrectly
snapped, causing blurry/clipped text.

This change reverts that original fix. And instead, it snaps the
source_transform of the reference frame itself when it is sampled,
rather than the accumulated coordinate-system-relative scale_offset of
the scroll frame. Additionally, it only snaps the offset if it is an
animation (including zoom), and static offsets are left unsnapped.

Differential Revision: https://phabricator.services.mozilla.com/D76298

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/a8499f9c0d024b7287f3e0cb13bc56f5f3f57753
@moz-gfx
Copy link
Author

moz-gfx commented May 28, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2020

📌 Commit 55c44f3 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2020

Testing commit 55c44f3 with merge 384cf97...

@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2020

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing 384cf97 to master...

@bors-servo bors-servo merged commit 384cf97 into servo:master May 28, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.