Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3974
Merged
Conversation
…ent memory exhaustion r=gw Differential Revision: https://phabricator.services.mozilla.com/D78072 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/6fbc33061f0de92c70e33981f4853d219d9aaf30
…iction changes. r=kvark * Maintain a running total of bytes allocated in both standalone and shared cache regions. This is used as a threshold to know when to force a mid-frame eviction. Previously, as soon as the currently allocated set of shared textures were full, we'd force an eviction. This means that in typical use cases, we were forcing an eviction as soon as the texture cache is > 16 MB, which is inefficient. * Separate out picture cache eviction from the normal cache eviction path. This will be important in the next patch which will change the eviction algorithm for all shared / standalone entries. * Remove Eviction::Eager as a policy option for shared and standalone textures. As part of this, switch render task cache entries to use Eviction::Auto. This is a better option anyway, there is no real benefit to evicting render tasks as soon as possible - they should be expired based on usage, just as for normal cache entries. Differential Revision: https://phabricator.services.mozilla.com/D77983 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a900282391e15be8a8f9ed9782a550ff6be11cc7
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 4, 2020
Sync changes from mozilla-central gfx/wr
|
|
…310, 1643238, 1643240. CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/0d21bdf3fc0118b553c6543ddbff927a2c70cb96
|
@bors-servo r=auto |
|
|
|
…dback r=gw When handling mix-blend readbacks, we need to calculate the origin of the source picture in the backdrop's space. Before this patch, this was done by scaling the source picture origin by the backdrop's device pixel scale. However, this is the incorrect scaling; We really want the relative scale between source and backdrop instead. This patch computes the relative scaling from the device pixel scale of both the source and backdrop pictures. This bug likely went unnoticed because the device pixel scale used to be 1 in most cases, but now we sometimes increase the device pixel scale for raster roots. Differential Revision: https://phabricator.services.mozilla.com/D78217 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b4db2b3b6b8e0fecdcfd14d7129e9372cb9666de
…iction changes. r=Bert,kvark * Maintain a running total of bytes allocated in both standalone and shared cache regions. This is used as a threshold to know when to force a mid-frame eviction. Previously, as soon as the currently allocated set of shared textures were full, we'd force an eviction. This means that in typical use cases, we were forcing an eviction as soon as the texture cache is > 16 MB, which is inefficient. * Separate out picture cache eviction from the normal cache eviction path. This will be important in the next patch which will change the eviction algorithm for all shared / standalone entries. * Remove Eviction::Eager as a policy option for shared and standalone textures. As part of this, switch render task cache entries to use Eviction::Auto. This is a better option anyway, there is no real benefit to evicting render tasks as soon as possible - they should be expired based on usage, just as for normal cache entries. Differential Revision: https://phabricator.services.mozilla.com/D77983 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/41191094ff58232189fa23459130a070def08045
|
@bors-servo r=auto |
|
|
Instead of using the default TreePrinter implementation which sends output to stdout, collect it into a Vec<u8> and use the debug! macro to log it, which sends it to a more useful destination (logcat) on Android. Depends on D78536 Differential Revision: https://phabricator.services.mozilla.com/D78537 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/4e89164de2d6bbefbbabcce580658a69d12b149b
|
@bors-servo r=auto |
|
|
…it won't overflow r=Bert Differential Revision: https://phabricator.services.mozilla.com/D78555 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/e35471f49dcdcfb0528fa4f207783bffc7455d12
|
@bors-servo r=auto |
|
|
|
@bors-servo r- |
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJun 4, 2020
No description provided.