Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3981
Merged
+0
−0
Conversation
The main idea here is lifting the storages of batches, instances, and instance rects,higher up. Currently, to the level of the alpha/opaque batcher. In the short term, this would result in less heap allocations on frame building. For example, we no longer have a Vec<InstanceRect> per batch, stored in a separate Vec, and we don't have a separate Vec<InstanceData> per batch. There is also a matter of code refactor and cleanup that could make our life better. In the longer term, once Angle is updated, we'll be able to lift the VBO updates up accordingly, and use baseInstance drawing with them. Sub-commits: - Minor refactor of the batch intersection logic - Instance stacks for transparent alpha batches - Use instance stacks for opaque batches as well - Implement and re-enable batch list merging - Encapsulate instance stack LRU indexing into a class - Internal BatchList type, bumped StackIndex size. - Adjust the tests - Test the stack count of 4 Differential Revision: https://phabricator.services.mozilla.com/D76715 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/88406054eb6c146cf607429a09a8f3814bbbb5e5
… 456219-1a.html. CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/29972ad4261517555b4e74990f402426136a357e
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJun 12, 2020
No description provided.