Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3994
Merged
+3,270
−2,861
Conversation
…d of per-cluster. r=gw After this change, clusters just keep a range of indices in the prim list's instance array. Differential Revision: https://phabricator.services.mozilla.com/D80461 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/26fbdf4c708744a2f3a4201ba9c5b2823f0e3010
Differential Revision: https://phabricator.services.mozilla.com/D80693 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/42e0a75220262188ee410cd2a358a8d9541b4a98
Differential Revision: https://phabricator.services.mozilla.com/D80692 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/eb37b6753d82daee2d81d19caccac333d6acf8b9
…lt framebuffer. r=jimb For performance reasons in SWGL software compositors. to avoid unnecessary full-screen copies of the framembuffer, we need to allow those compositors to map their underlying widget surfaces and pass that buffer to SWGL so that they can be directly rendered to. That also requires supporting custom strides, as we can't always enforce the particular layout of the buffers handed off to us. To that end, InitDefaultFramebuffer is generalized to take such information and then many places where we rely on a specific hard-coded SWGL-calculated stride have been altered to deal with a caller-supplied stride. Differential Revision: https://phabricator.services.mozilla.com/D80267 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/671f7c62e83faa9f322a967a3a67917d3278ab9f
This vector is usually small, but on some pages it can be fairly large (500+ in https://forum.xda-developers.com/redmi-note-3/development for example). Differential Revision: https://phabricator.services.mozilla.com/D79855 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/93505e39bf57c56312fb7fc2a3cb33690aa68c1b
Differential Revision: https://phabricator.services.mozilla.com/D79857 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/9c4d5596e220df94aae6a0c7642a0751acb63831
Differential Revision: https://phabricator.services.mozilla.com/D79858 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/6203b2994812ede5c700eaa968a5163cc621cc3a
…r=gw This change just restructures the recycling added in previouscommits. Differential Revision: https://phabricator.services.mozilla.com/D80096 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/dc3d4d706d116b62efea36c190287f778aedb201
Differential Revision: https://phabricator.services.mozilla.com/D80178 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/d7ddc0cdffa285f9e6b19239651c214ae8cb68e9
…kvark Differential Revision: https://phabricator.services.mozilla.com/D80192 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/7cbc9b5f00f1b83e25c19be1d76e6a404415180d
…face_stack. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D80193 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/f26158a3994c694e89d8bdde15beb9cbe5aafa63
This patch a simple utility to help with pre-allocating vectors that we can't recycle and use it with the primitive headers. Differential Revision: https://phabricator.services.mozilla.com/D80194 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/ac1dec27b771d02de0d729b6c458924fcddf28ae
Vector reallocations in CompositeState::push_surface are taking about 2% of total frame building time before this patch. There was an effort at preallocating some with constant values but I suspect these constants haven't been updated along with picture cachign heuristics. Differential Revision: https://phabricator.services.mozilla.com/D80195 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/1e531a6c2590fc38bc1c0393f036b393e26f2118
…=kvark Differential Revision: https://phabricator.services.mozilla.com/D80203 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a16036b4b36cfa4dc083fa5a6fbc3db0adbc978f
Differential Revision: https://phabricator.services.mozilla.com/D80437 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/17684b39b0bac9bc1152f0057393c7ff8542a944
…of split planes into it. r=gw Differential Revision: https://phabricator.services.mozilla.com/D80438 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/e891a846e7f31ca81271dfeff1b5c501a61f3111
It would be wasteful to preallocate all batch builders because the majority of them have only a single batch, while typically only one will will have many batches. Thankfully we can acurately guess which pictures will produce many batches by checking whether they have more than one cluster. Differential Revision: https://phabricator.services.mozilla.com/D80469 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/45ef8e463b6ee4af10d09c6fd3be7a202644abd7
|
@bors-servo r=auto |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 24, 2020
Sync changes from mozilla-central gfx/wr
|
|
We detect empty scroll roots by checking the valid scrollable size of a frame, in order to avoid attaching picture cache slices to these redundant scroll frames. However, under some fractional zoom scenarios, rounding CSS pixels to device pixels can result in small rounding errors. Apply the same epsilon check that Gecko uses in APZ code in order to detect if a scroll frame is actually scrollable. Differential Revision: https://phabricator.services.mozilla.com/D80943 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/b425233628af9b3bfddcd4756940aac2444c8db1
|
@bors-servo r=auto |
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJun 24, 2020
No description provided.