Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #3996
Merged
Conversation
and others
added 2 commits
Jun 26, 2020
In various parts of the picture and mask code, we were casting the `clipped` rect to i32 (after rounding out). However, this can cause overflow panics when the origin of the rect is too big. Instead, treat the origin as f32 (which it was generally being converted to anyway), and only cast the size part to be i32 as required. This is safe since we know that the size has been clipped to the visible screen, so will always be safe to cast to i32. Differential Revision: https://phabricator.services.mozilla.com/D80968 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/4114f7f226439069ee24a52de4f6cd856beaa4f5
…stages. CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/61277d7e68aea4d3ea92f9ac2a2387bcb1a3b55f
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJun 26, 2020
No description provided.