Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #3999

Merged
merged 1 commit into from Jun 30, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Jun 30, 2020

No description provided.

Previously, tile cache instances were destroyed and recreated
each time a new scene was created, as they were embedded inside
the picture primitives. An elaborate but complicated system was
used to retain important state (such as native surfaces, primitive
dependencies) across new scenes.

This patch moves the tile cache instances to be stored inside the
render backend. It removes the previous code for retaining state
for each tile cache. Instead, tile caches are created / reused /
destroyed during `new_async_scene_ready`.

This removes quite a bit of complexity. More importantly, it is
another step towards being able to cache and retain state such
as primitive tile assignments and visibility state across both
new frames and scenes.

Differential Revision: https://phabricator.services.mozilla.com/D81487

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/123557e8dd5e604bfb885d78912096006bae3600
@moz-gfx
Copy link
Author

moz-gfx commented Jun 30, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2020

📌 Commit e405347 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2020

Testing commit e405347 with merge 41394e3...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 30, 2020

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing 41394e3 to master...

@bors-servo bors-servo merged commit 41394e3 into servo:master Jun 30, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.