Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #4001

Merged
merged 3 commits into from Jul 2, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Jul 1, 2020

No description provided.

Fix ODR violation: type of GLboolean must match gleam, else the unsafe{}
glue code will corrupt the parameters (and go out of bounds in
GetBooleanv). "Composite" was getting a garbage value for "flip".

Differential Revision: https://phabricator.services.mozilla.com/D81618

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/43a6b9c2550c1ee8a2e5a49631e6bf76dbacd8d0
@moz-gfx
Copy link
Author

moz-gfx commented Jul 1, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2020

📌 Commit ca36708 has been approved by auto

nical added 2 commits Jul 1, 2020
This greatly reduces the number of vector reallocations happening while building primitive lists. On the difficult cases like youtube front page the reduction is a bit more than 50%, and more in other pages I tested. More importantly it dramatically reduces the amount of the most expensive of these reallocations which are when the vector is starting to get large.

Differential Revision: https://phabricator.services.mozilla.com/D81725

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/8deaca01428d9ff281089c80d15c1b7fbfb25670
@moz-gfx
Copy link
Author

moz-gfx commented Jul 1, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2020

📌 Commit ca36708 has been approved by auto

@staktrace
Copy link
Contributor

staktrace commented Jul 1, 2020

@staktrace
Copy link
Contributor

staktrace commented Jul 1, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 1, 2020

📌 Commit ca36708 has been approved by auto

@staktrace
Copy link
Contributor

staktrace commented Jul 1, 2020

@jdm bors taking a holiday too?

@jdm
Copy link
Member

jdm commented Jul 2, 2020

@jdm
Copy link
Member

jdm commented Jul 2, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 2, 2020

📌 Commit dc80b63 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 2, 2020

Testing commit dc80b63 with merge cf8dabe...

@jdm
Copy link
Member

jdm commented Jul 2, 2020

@staktrace Github's webhooks had a bunch of issues today, so the latest push to the branch wasn't delivered to the homu webhook. This situation can be identified by comparing the hash that homu is reporting is approved against the hash of the latest commit in the branch.

@bors-servo
Copy link
Contributor

bors-servo commented Jul 2, 2020

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing cf8dabe to master...

@bors-servo bors-servo merged commit cf8dabe into servo:master Jul 2, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
@staktrace
Copy link
Contributor

staktrace commented Jul 2, 2020

@jdm Good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.