Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #4003
Merged
Conversation
added 2 commits
Jul 2, 2020
swgl::Context::init_default_framebuffer takes two new arguments, for providing a frame buffer owned by something else. swgl::Context::get_color_buffer returns an extra value, describing the stride of the buffer in addition to the width. Differential Revision: https://phabricator.services.mozilla.com/D81896 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/5f34493d83d344553bcd2bd7879b05082908e5ba
…WGL. r=lsalzman The `clear_caches_with_quads` flags is meant to work around a bug in some drivers' scissored clears, but its implementation uses the `GL_ALWAYS` depth comparison function, which SWGL doesn't support. SWGL does scissored clears very well, so simply turning this workaround off on SWGL avoids the problem and gets good results. Of course we could just make SWGL support `GL_ALWAYS`, but that would be kind of annoying, since it basically disables depth checks altogether, and we want to use entirely different paths when depth checks aren't needed. Differential Revision: https://phabricator.services.mozilla.com/D81918 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/6661db82a5dbed508d1f10f9a242ceefa626af5f
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJul 2, 2020
No description provided.