Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #4006
Merged
+19
−13
Conversation
added 2 commits
Jul 6, 2020
…=nical Previously, we would defer calculation of whether a filter was a no-op until frame building. However, this complicates decisions related to which clips apply to which surfaces. Now, this decision is made during scene building. This makes things more consistent during frame building, which we can take advantage of in future. It also makes things like render target allocations slightly more predictable. Differential Revision: https://phabricator.services.mozilla.com/D82133 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/fd9bbd6162d2314b58f8a163d67efebdbb52b06a
Even when picture caching is disabled, we want to create the wrapping picture elements for these slices, to simplify some upcoming patches (we can assume that the picture cache elements are always present). The dynamic check at the start of FrameBuilder::build ensures that these are pass-through pictures when picture caching is disabled. In future, we'll also take advantage of this to track dirty regions in the disabled case, to allow partial present to work in all scenarios. Differential Revision: https://phabricator.services.mozilla.com/D82134 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/c87a20a004c4f6de9c1e50cb9692851ed1d78519
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJul 6, 2020
No description provided.