Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #4012

Merged
merged 4 commits into from Jul 14, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Jul 14, 2020

No description provided.

Glenn Watson and others added 4 commits Jul 14, 2020
This reduces the size of intern handles, which drops the size of
the PrimitiveInstance structure from 80 bytes to 64 bytes. This
has a significant performance improvement on pages with large
numbers of primitives.

It also opens up some future optimization work related to text
run interning costs, which will be a performance win on many pages.

Differential Revision: https://phabricator.services.mozilla.com/D83281

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/7fbefca418f395f90429a2d0acb09720578c8f46
we only draw quads, and for quads we have a fixed vertex buffer with positions.
If we get stop using instancing, we'll no longer have the luxury of 4 vertices there.
Given that they are trivial to compute, it seems simpler to just do that in the shader today.
So this PR is a required step on the way to instance-less rendering.

Differential Revision: https://phabricator.services.mozilla.com/D83391

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/ca1168e024b901c0c8cd1a8d3f2183b166b45806
This reduces the size of intern handles, which drops the size of
the PrimitiveInstance structure from 80 bytes to 64 bytes. This
has a significant performance improvement on pages with large
numbers of primitives.

It also opens up some future optimization work related to text
run interning costs, which will be a performance win on many pages.

Differential Revision: https://phabricator.services.mozilla.com/D83281

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/c019e0c77d80d5e28e94a1fd5799fb42c66ebea6
@moz-gfx
Copy link
Author

moz-gfx commented Jul 14, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

📌 Commit 4056061 has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

Testing commit 4056061 with merge e4e4b03...

@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2020

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing e4e4b03 to master...

@bors-servo bors-servo merged commit e4e4b03 into servo:master Jul 14, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.