Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #4014
Merged
Conversation
…11 on a CLOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/3331412297ae61337781969d5602edc1a1a88ae1
I found it hard to understand the code that builds shader features, and even harder to modify it with a new feature. This PR refactors the shader building code by removing the macro and introducing a FeatureList abstraction, internally. It also sorts the features on both ends (alternatively, we could use a set). Differential Revision: https://phabricator.services.mozilla.com/D83455 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/a23787eb4292aa25e06c907adfa1524c2dcd3857
Differential Revision: https://phabricator.services.mozilla.com/D83420 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/473aa541ba0d351afec29084c62604abc22c5221
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJul 15, 2020
No description provided.