Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync changes from mozilla-central gfx/wr #4017
Merged
Conversation
…dreno crash. r=gw On some Adreno 505 and 506 devices we are encountering driver crashes during glLinkProgram(). The only circumstance in which we have been able to reproduce locally is when the show-overdraw debug option is enabled. The reason appears to be that, due to shader optimisation, the debug overdraw variants of many shaders have identical source code. The crash seems to occur when linking a shader which has identical source code to a previously linked shader. This does not, however, explain the non-insignificant numbers of crashes in the wild because a) it's unlikely many users are enabling overdraw debugging, and b) some crash reports predate the commit which enabled shader optimisation. However, it is possible that for a different reason we are compiling multiple shaders with identical source code. To attempt to work around this crash this change adds a random comment to the end of each shader source string, on the affected devices. Differential Revision: https://phabricator.services.mozilla.com/D83571 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/bbe5ed51273b2a3a90c736b024f3e27cf01314aa
…LOSED TREE [ghsync] From https://hg.mozilla.org/mozilla-central/rev/e76ed046c4f956a5ce7c83e3813ef35242d4e86e
…gw,jrmuizel we only draw quads, and for quads we have a fixed vertex buffer with positions. If we get stop using instancing, we'll no longer have the luxury of 4 vertices there. Given that they are trivial to compute, it seems simpler to just do that in the shader today. So this PR is a required step on the way to instance-less rendering. It appears that we are hitting a driver bug with Intel on macOS, where scissored clears don't work properly if we render without per-vertex attributes. It doesn't make a ton of sense, but switching to quad clears appears to fix it for me. Added the corresponding entry to the wiki - https://github.com/servo/webrender/wiki/Driver-issues#bug-1652763---glitches-on-macos-intel-with-clears Differential Revision: https://phabricator.services.mozilla.com/D83391 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/697243e0434b814a992e1c9356f95517f4854b07
…dreno crash. r=gw On some Adreno 505 and 506 devices we are encountering driver crashes during glLinkProgram(). The only circumstance in which we have been able to reproduce locally is when the show-overdraw debug option is enabled. The reason appears to be that, due to shader optimisation, the debug overdraw variants of many shaders have identical source code. The crash seems to occur when linking a shader which has identical source code to a previously linked shader. This does not, however, explain the non-insignificant numbers of crashes in the wild because a) it's unlikely many users are enabling overdraw debugging, and b) some crash reports predate the commit which enabled shader optimisation. However, it is possible that for a different reason we are compiling multiple shaders with identical source code. To attempt to work around this crash this change adds a random comment to the end of each shader source string, on the affected devices. Differential Revision: https://phabricator.services.mozilla.com/D83571 [ghsync] From https://hg.mozilla.org/mozilla-central/rev/c08d4fe356e52e3e61d18765f9256d143687efda
|
@bors-servo r=auto |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moz-gfx commentedJul 15, 2020
No description provided.