Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IsEnabled #404

Merged
merged 1 commit into from Sep 14, 2016
Merged

Implement IsEnabled #404

merged 1 commit into from Sep 14, 2016

Conversation

@ofekd
Copy link
Contributor

ofekd commented Sep 14, 2016

Part of servo/servo#13040

Not sure that the way I converted GLboolean to bool is correct


This change is Reviewable

@jdm
Copy link
Member

jdm commented Sep 14, 2016

@bors-servo: r+
We have the same pattern elsewhere in the file, so that's fine.

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

📌 Commit 69a761a has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

Testing commit 69a761a with merge ae13e5d...

bors-servo added a commit that referenced this pull request Sep 14, 2016
Implement IsEnabled

Part of servo/servo#13040

Not sure that the way I converted `GLboolean` to `bool` is correct

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

💔 Test failed - status-travis

@jdm
Copy link
Member

jdm commented Sep 14, 2016

I guess we need to update the Cargo.toml to use the new gleam.

@ofekd ofekd force-pushed the ofekd:implement-webgl-isEnabled branch from 69a761a to aa5f40e Sep 14, 2016
@ofekd
Copy link
Contributor Author

ofekd commented Sep 14, 2016

@jdm Done

@jdm
Copy link
Member

jdm commented Sep 14, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

📌 Commit aa5f40e has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

Testing commit aa5f40e with merge 3b12ffb...

bors-servo added a commit that referenced this pull request Sep 14, 2016
Implement IsEnabled

Part of servo/servo#13040

Not sure that the way I converted `GLboolean` to `bool` is correct

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/404)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented Sep 14, 2016

Oops, we need to publish gleam.

@jdm jdm closed this Sep 14, 2016
@jdm jdm reopened this Sep 14, 2016
@jdm
Copy link
Member

jdm commented Sep 14, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

📌 Commit aa5f40e has been approved by jdm

@jdm
Copy link
Member

jdm commented Sep 14, 2016

@bors-servo: retry

@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

Testing commit aa5f40e with merge db07ba3...

bors-servo added a commit that referenced this pull request Sep 14, 2016
Implement IsEnabled

Part of servo/servo#13040

Not sure that the way I converted `GLboolean` to `bool` is correct

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Sep 14, 2016

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit aa5f40e into servo:master Sep 14, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Testing commit aa5f40e with merge db07ba3...
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.