Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes from mozilla-central gfx/wr #4062

Merged
merged 3 commits into from Aug 18, 2020
Merged

Conversation

@moz-gfx
Copy link

moz-gfx commented Aug 18, 2020

No description provided.

Glenn Watson and others added 3 commits Aug 18, 2020
…=kvark

Although real world content generally has a small number of picture
cache slices (typically < 8), it's possible to create contrived
cases that create large numbers of picture cache slices. In these
cases, we want to ensure that we don't create too many slices, to
avoid allocating too much GPU memory for cached surface tiles.

Previously, at the end of scene building, WR would check if the
slice count exceeded the limit, and then merge all of those into
a single slice if required.

Instead of that, WR now retains the first MAX-1 slices, and just
creates the last slice to be a container for all subsequent prims,
if we hit that limit.

This means we can rely on the slice a prim is assigned never
changing. From this, we will be able to eliminate the shared
compositor clips once during scene building, rather than needing
to check these during every frame build.

Differential Revision: https://phabricator.services.mozilla.com/D87205

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/5b2ffcf4d6d831c662685f17cda7e335d5f60dcf
@moz-gfx
Copy link
Author

moz-gfx commented Aug 18, 2020

@bors-servo r=auto

@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2020

📌 Commit c1ce6fa has been approved by auto

@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2020

Testing commit c1ce6fa with merge b9127b7...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 18, 2020

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing b9127b7 to master...

@bors-servo bors-servo merged commit b9127b7 into servo:master Aug 18, 2020
2 checks passed
2 checks passed
Community-TC (pull_request) TaskGroup: success
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.