Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only allow root layer to overscroll #436

Closed

Conversation

@gterzian
Copy link
Member

gterzian commented Oct 9, 2016

WIP for servo/servo#13249


This change is Reviewable

true
} else {
false
}

This comment has been minimized.

@KiChjang

KiChjang Oct 9, 2016

Member

Instead of returning true or false, you can simply return:
overscroll_amount.width != 0.0 || overscroll_amount.height != 0.0

This comment has been minimized.

@gterzian

gterzian Oct 9, 2016

Author Member

@KiChjang cheers! 👍

@gterzian gterzian force-pushed the gterzian:prevent_non_root_layer_overscroll branch 2 times, most recently from 2bdabed to f77e258 Oct 9, 2016
@gterzian gterzian force-pushed the gterzian:prevent_non_root_layer_overscroll branch from f77e258 to 9395f46 Oct 15, 2016
@gterzian
Copy link
Member Author

gterzian commented Oct 22, 2016

Closing, in favor of #465

@gterzian gterzian closed this Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.