Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix Android and ARM compilation options #440
Merged
Conversation
|
@bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 11, 2016
Fix Android and ARM compilation options This fixes Android build issues caused by [missing GL calls](https://github.com/servo/gleam/blob/master/src/gl.rs#L206) in the profiling code. It seems these *are* available on ARM though, so I enabled building the profile code for ARM devices. (This is a fix for servo/servo#13154) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/440) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mmatyas commentedOct 11, 2016
•
edited by larsbergstrom
This fixes Android build issues caused by missing GL calls in the profiling code. It seems these are available on ARM though, so I enabled building the profile code for ARM devices.
(This is a fix for servo/servo#13154)
This change is