Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBring the border radius back on Linux. #446
Merged
Conversation
I just noticed while reading over #444 that this same line is commented for clipping. This was making the alpha component of the border radius being always zero. This brings back the border radius on Linux. I didn't notice any other issue. Not totally sure why this only happens on Intel cards though, probably is a floating point math issue?
|
r? @glennw The two last commits are just cleanups though. |
|
@mrobinson Does this make sense as a fix? (It seems like the clip/non-clip shader should be consistent with use of that distance_from_line anyway)? |
|
This change looks okay to me, especially if it fixes an issue. I didn't mean to include the gradual fade out here (I meant to delete the commented-out line), but clearly something is wrong. At some point after this lands, I plan to take a look the bug again in more detail. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 18, 2016
Bring the border radius back on Linux. I just noticed while reading over #444 that this same line is commented for clipping. This was making the alpha component of the border radius being always zero. This brings back the border radius on Linux. I didn't notice any other issue. Not totally sure why this only happens on Intel cards though, probably is a floating point math issue? Also, this improves the appearance with `LIBGL_ALWAYS_SOFTWARE=1` too, which I guess is the canonical representation. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/446) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedOct 18, 2016
•
edited by larsbergstrom
I just noticed while reading over #444 that this same line is commented for
clipping. This was making the alpha component of the border radius being always
zero.
This brings back the border radius on Linux. I didn't notice any other issue.
Not totally sure why this only happens on Intel cards though, probably is a
floating point math issue?
Also, this improves the appearance with
LIBGL_ALWAYS_SOFTWARE=1too, which I guess is the canonical representation.This change is