Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRewrite much of the clipper to support rounded border corners in fuller generality and fix some bugs. #46
Conversation
generality and fix some bugs. Allows gradients to be clipped to rounded border corners, improving the look of rounded elements' backgrounds. The clipper no longer takes mask texture coordinates as input, although it still supplies them as output. This is because it may need to manufacture mask texture coordinates for rounded corner alpha masks. We were never relying on this feature for anything, so it does not cause a problem.
|
Nice! |
glennw
added a commit
that referenced
this pull request
Oct 21, 2015
Rewrite much of the clipper to support rounded border corners in fuller generality and fix some bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedOct 21, 2015
Allows gradients to be clipped to rounded border corners, improving the look of
rounded elements' backgrounds.
The clipper no longer takes mask texture coordinates as input, although it
still supplies them as output. This is because it may need to manufacture mask
texture coordinates for rounded corner alpha masks. We were never relying on
this feature for anything, so it does not cause a problem.