Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some information about coordinate systems in webrender. #486
Conversation
This is just a start - we need to document each API that deviates from the conventions listed here, and also investigate using strongly typed units where it makes sense to.
|
r? @pcwalton |
|
Just to confirm - when you say CSS pixels, I'm assuming you mean it doesn't include CSS transforms, and instead those transforms are put into the |
|
@staktrace Yep, that's right. |
|
@bors-servo r=mrobinson |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 27, 2016
Add some information about coordinate systems in webrender. This is just a start - we need to document each API that deviates from the conventions listed here, and also investigate using strongly typed units where it makes sense to. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/486) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedOct 27, 2016
•
edited by larsbergstrom
This is just a start - we need to document each API that
deviates from the conventions listed here, and also investigate
using strongly typed units where it makes sense to.
This change is