Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix GL stencil state #500
Merged
Fix GL stencil state #500
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2016
Fix GL stencil state This was a typo from #480 Found out by qApitrace log: > major api error 14: GL_INVALID_ENUM in glDisable(GL_STENCIL) Perhaps, we should check for gl errors in the code too. We seem to only do that for WebGL commands at this point. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/500) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedOct 28, 2016
•
edited
This was a typo from #480
Found out by qApitrace log:
Perhaps, we should check for gl errors in the code too. We seem to only do that for WebGL commands at this point.
This change is