Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Image masked screen rectangle #530
Closed
Conversation
|
Discussed with @glennw . It appears that we first need the image masking shader logic to work properly in local space. That's going to be a small change. And then, we'll be introducing the masking tiles (in screen space) to either replace the local image masking or be optional alternative to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedNov 4, 2016
•
edited
Includes #529
Renames
local_rect->screen_rectfor theImageMaskData, since the idea now is that the mask is always screen-aligned, and we are baking anything non-aligned into the off-screen textures (#498).This change is