Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Image masked screen rectangle #530

Closed
wants to merge 2 commits into from
Closed

Conversation

@kvark
Copy link
Member

kvark commented Nov 4, 2016

Includes #529
Renames local_rect -> screen_rect for the ImageMaskData, since the idea now is that the mask is always screen-aligned, and we are baking anything non-aligned into the off-screen textures (#498).


This change is Reviewable

@kvark kvark changed the title Screen rect [WIP] Image masked screen rectangle Nov 4, 2016
@kvark
Copy link
Member Author

kvark commented Nov 4, 2016

Discussed with @glennw . It appears that we first need the image masking shader logic to work properly in local space. That's going to be a small change. And then, we'll be introducing the masking tiles (in screen space) to either replace the local image masking or be optional alternative to it.

@kvark kvark closed this Nov 4, 2016
@kvark kvark deleted the kvark:screen_rect branch Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.