Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSwitch AlphaBatchKeyFlags to use bitflags! crate. #541
Conversation
|
Nearly there, just one more fix needed! :) |
webrender/src/tiling.rs
Outdated
| } else { | ||
| AlphaBatchKeyFlags::empty() | ||
| }; | ||
| let flags = AXIS_ALIGNED | needs_clipping_flag; |
This comment has been minimized.
This comment has been minimized.
glennw
Nov 8, 2016
Member
Sorry, my last comment was not very well described. We still need to check if transform_kind == AxisAligned, and only set the AXIS_ALIGNED flag if that's true. When that's done, the fn transform_kind() function will work correctly, as it will return AxisAligned if the AXIS_ALIGNED bit was set, and Complex otherwise.
|
@moriturus Looks good, thanks! Would you mind squashing these into one commit and then I'll get it merged. |
|
@bors-servo r+ |
|
|
|
Thanks! |
bors-servo
added a commit
that referenced
this pull request
Nov 9, 2016
Switch AlphaBatchKeyFlags to use bitflags! crate. Sorry about my mistake on #539 then I re-open this PR. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/541) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
moriturus commentedNov 8, 2016
•
edited
Sorry about my mistake on #539 then I re-open this PR.
This change is