Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix filename overrides from losing extension #570
Merged
Conversation
|
as long as it works :) |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 17, 2016
Fix filename overrides from losing extension
`.with_extension(".glsl")` ends up nuking `.vs` and `.fs`. Whoops.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/570)
<!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vvuk commentedNov 17, 2016
•
edited by larsbergstrom
.with_extension(".glsl")ends up nuking.vsand.fs. Whoops.This change is