Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake ipc-channel an optional feature. #572
Merged
Conversation
This allows clients to opt-in to IPC for communication if required. Otherwise, in-process rust channels are used, avoiding serialization.
|
r? @pcwalton |
|
cc @jrmuizel |
|
@bors-servo: r+ |
|
|
| use serde::{Deserialize, Serialize}; | ||
| use std::io::Error; | ||
|
|
||
| #[cfg(feature = "ipc")] |
This comment has been minimized.
This comment has been minimized.
kvark
Nov 17, 2016
Member
given that everything in this module is split between ipc and non-ipc, I'd rather see separate files channel.rs and channel_ipc.rs with a single switch upon including them.
This comment has been minimized.
This comment has been minimized.
bors-servo
added a commit
that referenced
this pull request
Nov 18, 2016
Make ipc-channel an optional feature. This allows clients to opt-in to IPC for communication if required. Otherwise, in-process rust channels are used, avoiding serialization. This fixes #558. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/572) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedNov 17, 2016
•
edited by larsbergstrom
This allows clients to opt-in to IPC for communication if required.
Otherwise, in-process rust channels are used, avoiding serialization.
This fixes #558.
This change is