Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change font platforms to work with device pixels directly. #583

Merged
merged 1 commit into from Nov 28, 2016

Conversation

@glennw
Copy link
Member

glennw commented Nov 22, 2016

This means that glyph keys are correctly hashed and
cached when the device pixel ratio is changed dynamically.

This is a step towards support zoom functionality.


This change is Reviewable

This means that glyph keys are correctly hashed and
cached when the device pixel ratio is changed dynamically.

This is a step towards support zoom functionality.
@glennw
Copy link
Member Author

glennw commented Nov 22, 2016

r? @pcwalton and also @vvuk for the Windows parts.

I have built and run this on Linux, Mac, Windows and it all looks correct.

@glennw
Copy link
Member Author

glennw commented Nov 22, 2016

@vvuk
Copy link
Contributor

vvuk commented Nov 23, 2016

r+ on the windows parts

@pcwalton
Copy link
Collaborator

pcwalton commented Nov 28, 2016

@bors-servo: r+

Nice! This simplifies code too :)

@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2016

📌 Commit 0d42700 has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2016

Testing commit 0d42700 with merge 34ce8f2...

bors-servo added a commit that referenced this pull request Nov 28, 2016
Change font platforms to work with device pixels directly.

This means that glyph keys are correctly hashed and
cached when the device pixel ratio is changed dynamically.

This is a step towards support zoom functionality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/583)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 28, 2016

☀️ Test successful - status-travis

@bors-servo bors-servo merged commit 0d42700 into servo:master Nov 28, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:glyph-dp branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.