Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd specific shaders for rectangles with CLIP feature. #591
Conversation
Having the base rectangle shader include clip makes the software mesa implementation (somewhat) slower for reftests. This is enough of a timing difference that it triggers a lot of intermittent test failures in Servo. Instead, include a simple rectangle shader for workloads that don't have a clip mask. The other shaders are typically more expensive and not used as frequently by the reftests, so hopefully this change is enough to work around the Servo intermittent bugs.
|
r? @kvark and @mrobinson |
|
@bors-servo r+ Hopefully this fixes the issues with the Servo tests. |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 24, 2016
Add specific shaders for rectangles with CLIP feature. Having the base rectangle shader include clip makes the software mesa implementation (somewhat) slower for reftests. This is enough of a timing difference that it triggers a lot of intermittent test failures in Servo. Instead, include a simple rectangle shader for workloads that don't have a clip mask. The other shaders are typically more expensive and not used as frequently by the reftests, so hopefully this change is enough to work around the Servo intermittent bugs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/591) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedNov 24, 2016
•
edited by larsbergstrom
Having the base rectangle shader include clip makes the software
mesa implementation (somewhat) slower for reftests. This is enough
of a timing difference that it triggers a lot of intermittent
test failures in Servo.
Instead, include a simple rectangle shader for workloads that
don't have a clip mask.
The other shaders are typically more expensive and not used as
frequently by the reftests, so hopefully this change is enough
to work around the Servo intermittent bugs.
This change is