Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake sure to call write_clip from vertex shader (ps_yuv_image.vs.glsl) #598
Conversation
|
Thanks for the investigation and the fix! |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 27, 2016
Make sure to call write_clip from vertex shader (ps_yuv_image.vs.glsl) Fix to [Issue #594](#594) where write_clip was not being called for a future call to do_clip, causing an error with certain clipping attributes not having been written for the fragment shader to use. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/598) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jaredpetker commentedNov 26, 2016
•
edited by larsbergstrom
Fix to Issue #594 where
write_clip was not being called for a future call to do_clip, causing an
error with certain clipping attributes not having been written for the
fragment shader to use.
This change is