Implement scroll handoff #599

gterzian · 2016-11-27T14:18:58Z

"If a new scroll gesture starts while you're already scrolled all the way to the edge of the scrollable element under the mouse, then the scroll will be handed off to the next outer scrollable element which is actually scrollable in that direction" servo/servo#13249 (comment)

Page used for testing can be found online here.

This change is

glennw · 2016-11-28T03:07:55Z

@gterzian OK, I tested this on Linux. It doesn't seem to break anything, but it also doesn't seem to work - the old behaviour persists where if I keep the cursor in the nested scroll area, and scroll to the bottom, it doesn't scroll the outer scroll area. I tried this with both a mouse wheel and also scrolling on my touchpad. I might have some time during the week to debug this and see what's going on.

glennw · 2016-11-28T05:24:09Z

@gterzian I did a little bit of investigation on Linux. It looks like on Linux we never receive TouchStart / TouchEnd events. From a very quick look in glutin, it seems that it does provide these events on Linux, but only for touch events (although I don't receive them even when using the touchpad).

I'm not actually sure whether we should expect to rely on always getting a start/end event, or if we should expect to receive Scroll / Move events without a corresponding start / end. Perhaps @mbrubeck could comment on this?

I wonder if it's possible to update the logic in this PR to work without relying on the start / end events?

glennw · 2016-11-28T05:24:47Z

@gterzian PS the above now explains why we see these issues on Linux and they are unrelated to the CAN_OVERSCROLL flag.

gterzian · 2016-11-28T07:23:08Z

@glennw thanks a lot for the investigation! This makes a lot of sense and also explains why #600 would break scrolling altogether.

I will have to investigate more whether the desired behaviour can be implemented without relying on start/end scroll phases, or whether those can be added for linux...

mstange · 2016-11-28T16:44:07Z

Yes, macOS is the only platforms that groups wheel events into units, by giving you start+end events with phases like NSEventPhaseBegan and NSEventPhaseEnded. Unless you connect a traditional USB mouse to your Mac - in that case, even macOS can't help you, because the hardware has no way to tell whether your finger is still on the scroll wheel. (In terms of native wheel events, USB mouse wheel ticks result in wheel events with scroll phase NSEventPhaseNone.)

So on all non-Mac platforms, and on Mac for events with NSEventPhaseNone, you need to do your own grouping of events. In Firefox, we do this based on pause time and mouse movement. The code is around here: http://searchfox.org/mozilla-central/source/gfx/layers/apz/src/InputBlockState.cpp#361
New wheel events are treated as part of the current wheel event group if the wheel block state is "in transaction".

bors-servo · 2016-11-28T23:42:47Z

☔ The latest upstream changes (presumably #540) made this pull request unmergeable. Please resolve the merge conflicts.

glennw · 2016-11-28T23:44:41Z

@mstange Thanks for the info. @gterzian It seems this is turning into a larger issue than originally expected! I wonder if we should be doing that event grouping in WR or in Servo - any thoughts @mbrubeck or others?

gterzian · 2016-11-29T14:20:23Z

@glennw @mstange Thank you for your input. I would be happy to work on this 'event grouping', either in Servo or here in Webrender...

gterzian · 2016-11-30T16:04:25Z

Ok so looking at the Firefox code, it seems that the input events are grouped together into transactions, where a 'transaction' represents pretty much a continuous scroll gesture. The scroll handoff logic is handled together with the transaction logic, for example see http://searchfox.org/mozilla-central/source/gfx/layers/apz/src/InputBlockState.cpp#524

In Servo it's currently Webrender that does the scrolling, and Webrender receives those scroll events from the compositor (from looking at this it seems the compositor is already grouping events together in some way: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L218).

I guess the choice we face is either to implement a 'scroll transaction' in compositor, and send events to webrender always with either Start(new transaction), Move(current transaction), and End(end transaction) phases, and then my current code will pretty much work, and it's webrender that would handle the scroll handoff logic, while remaining unaware of the transaction logic.

We could also implement those transactions in webrender. By simply always starting/ending the transaction when we do receive Start/End phases, and otherwise rely on our own logic when we receive only Move events.

A downside of doing those transactions in WR might be that we don't know what the original event was, so we can't change our 'transaction logic' based on the scrolling hardware used. (in FF there is a base InputBlock class and subclasses for each type of hardware used for scrolling, see http://searchfox.org/mozilla-central/source/gfx/layers/apz/src/InputBlockState.h#26)

then again, implementing some quick and dirty transaction logic right here in webrender might be a good start...

Please let me know what you think...

glennw · 2016-11-30T21:29:31Z

I discussed with @mbrubeck - we think it makes sense to do the grouping the Servo compositor - that lets WR deal with the high level concept of scroll transactions, and leaves glutin to deal with raw events.

gterzian · 2016-12-01T07:42:24Z

@glennw great! thanks for your input, I will start looking around compositor...


        Auto merge of #14470 - gterzian:implement_scroll_transactions, r=mbru…

@glennw

…beck Implement scroll transactions  @glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by @mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14470)


        Auto merge of #14470 - gterzian:implement_scroll_transactions, r=mbru…

@glennw

…beck Implement scroll transactions  @glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by @mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14470)


        Auto merge of #14470 - gterzian:implement_scroll_transactions, r=mbru…

@glennw

…beck Implement scroll transactions  @glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by @mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14470)


        Auto merge of #14470 - gterzian:implement_scroll_transactions, r=mbru…

@glennw

…beck Implement scroll transactions  @glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by @mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14470)

gterzian · 2016-12-13T12:39:38Z

@glennw the Servo "scroll transaction" part has landed(servo/servo#14470), and I have rebased to remove the conflicts. It's actually hard to test it once again, because I see the Servo side of https://github.com/servo/webrender/pull/540/files has not landed yet...

I did test it extensively as part of the Servo PR.

Once thing to note is that some details are still left to be implemented: "the scroll will be handed off to the next outer scrollable element which is actually scrollable in that direction".

Currently I just hand-off the scroll to the root scroll layer(even though I think self.get_scroll_layer probably grabs the next outer scollable element, if only on the next scroll event).

I am certainly not checking for "which is actually scrollable in that direction".

Do you think it would be best to further work on those features in this PR, or rather look at this one has a good first step, and leave those notes in a follow-up issue on Servo?

glennw · 2016-12-21T03:23:51Z

I think it's fine to land this as a first step - it's a net improvement. I've landed the WR update in Servo, so it should be possible to rebase this, test it, and get it merged once the two formatting nits are fixed.

glennw · 2016-12-21T03:24:27Z

webrender/src/frame.rs

@@ -445,12 +480,12 @@ impl Frame {
            if CAN_OVERSCROLL {
                layer.stretch_overscroll_spring();
            }
-
+            


nit: extra space

glennw · 2016-12-21T03:24:27Z

webrender/src/frame.rs

            scrolled_a_layer = scrolled_a_layer ||
                layer.scrolling.offset != original_layer_scroll_offset ||
                layer.scrolling.started_bouncing_back;
        }
-
+        


nit: extra space

kvark

The PR is a bit over my head, but I don't see anything wrong with the code :)


        implement scroll handoff

gterzian · 2016-12-23T23:02:52Z

@glennw OK i've rebased off of 4474785 (there were some deps issues with the current head), tested on a Mac in 'normal' mode, as well as with overscroll turned off and with start/end event handling in compositor turned off as well.

Seems to work fine, when you have a chance to test in linux proper it would be much appreciated! 😄

glennw · 2017-01-03T21:08:18Z

@gterzian OK, I tested on Linux this morning - it doesn't seem to work for me on the test page referenced. I'll try to dig into why sometime this week.

gterzian · 2017-01-04T12:54:14Z

@glennw thanks!

glennw · 2017-01-17T13:20:26Z

@gterzian Apologies - I haven't tested this yet on Linux - will try to get to it during this week :)

glennw · 2017-01-17T16:00:33Z

@gterzian I'm unsure what changed, but this is working perfectly for me on Linux now :)

glennw · 2017-01-17T16:00:39Z

@bors-servo r+

bors-servo · 2017-01-17T16:00:40Z

📌 Commit d541621 has been approved by glennw

bors-servo · 2017-01-17T16:00:44Z

⌛ Testing commit d541621 with merge 6fa2cad...


        Auto merge of #599 - gterzian:handoff_scroll_when_end_of_layer_reache…

…d, r=glennw Implement scroll handoff "If a new scroll gesture starts while you're already scrolled all the way to the edge of the scrollable element under the mouse, then the scroll will be handed off to the next outer scrollable element which is actually scrollable in that direction" servo/servo#13249 (comment) Page used for testing can be found online [here](https://samuknet.github.io/test_cases/nestedScroll/).  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/599)

bors-servo · 2017-01-17T17:25:23Z

☀️ Test successful - status-travis

gterzian · 2017-01-18T07:56:24Z

@glennw thanks for all your help, it has been a long one! 😄


        servo: Merge #14470 - Implement scroll transactions (from gterzian:im…

@glennw

…plement_scroll_transactions); r=mbrubeck  @glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by @mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  Source-Repo: https://github.com/servo/servo Source-Revision: 92d380c399204d327e74771f5a9b8b2a343acecc


        servo: Merge #14470 - Implement scroll transactions (from gterzian:im…

…plement_scroll_transactions); r=mbrubeck  glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  Source-Repo: https://github.com/servo/servo Source-Revision: 92d380c399204d327e74771f5a9b8b2a343acecc UltraBlame original commit: 5e6f51510f8927cd014e93a7c9526da8465612cb


        servo: Merge #14470 - Implement scroll transactions (from gterzian:im…

…plement_scroll_transactions); r=mbrubeck  glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  Source-Repo: https://github.com/servo/servo Source-Revision: 92d380c399204d327e74771f5a9b8b2a343acecc UltraBlame original commit: 5e6f51510f8927cd014e93a7c9526da8465612cb


        servo: Merge #14470 - Implement scroll transactions (from gterzian:im…

…plement_scroll_transactions); r=mbrubeck  glennw Here is a first pass at faking Start scroll events by way of 'transactions', as suggested by mstange at servo/webrender#599 (comment) Since I still don't have a Linux environment available for testing(and my Mac doesn't have enough resources to run a VM at the moment), I tested this with both servo/webrender#599 and servo/webrender#600 on a Mac by: * disabling start and end events by removing the content of these two functions: https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1080 and https://github.com/servo/servo/blob/master/components/compositing/compositor.rs#L1093 * Setting `CAN_OVERSCROLL` to false for Mac OS in Webrender https://github.com/servo/webrender/blob/master/webrender/src/frame.rs#L29 * This PR also requires a `./mach update-cargo -a` The desired behavior of both Webrender PR's, based on my manual testing, now also works when there are no end or start scroll events provided by the os. The scroll transactions do not affect normal scrolling on Mac OS, and both PR still work as before on that platform. Both PR in Webrender need some re-basing and cleaning up, as does this one, and I first wanted to put this proposal forward, and also ask if someone has the time to do some testing in a real Linux environment... ---  - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #13249 (github issue number if applicable).  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____  Source-Repo: https://github.com/servo/servo Source-Revision: 92d380c399204d327e74771f5a9b8b2a343acecc UltraBlame original commit: 5e6f51510f8927cd014e93a7c9526da8465612cb

gterzian mentioned this pull request Nov 27, 2016

Implement scroll handoff #533

Closed

gterzian changed the title ~~Handoff scroll when end of layer reached~~ Handoff scroll when end of layer reached, and new gesture starts Nov 27, 2016

gterzian mentioned this pull request Nov 30, 2016

Keeping the currently scrolling layer, unless new gesture starts #600

Merged

gterzian mentioned this pull request Nov 30, 2016

Scrolling to end of element should start scrolling the parent element. servo/servo#13249

Closed

gterzian force-pushed the gterzian:handoff_scroll_when_end_of_layer_reached branch 2 times, most recently from 5f239a9 to 9a75258 Dec 6, 2016

gterzian mentioned this pull request Dec 6, 2016

Implement scroll transactions servo/servo#14470

Merged

3 of 5 tasks complete

gterzian force-pushed the gterzian:handoff_scroll_when_end_of_layer_reached branch from e2c2aa3 to df0e96a Dec 7, 2016

gterzian force-pushed the gterzian:handoff_scroll_when_end_of_layer_reached branch 4 times, most recently from 1b71327 to e0c4589 Dec 13, 2016

gterzian mentioned this pull request Dec 17, 2016

Implement home end key scrolling servo/servo#14141

Merged

3 of 4 tasks complete

glennw reviewed Dec 21, 2016

View changes

kvark reviewed Dec 22, 2016

View changes

gterzian force-pushed the gterzian:handoff_scroll_when_end_of_layer_reached branch from 55f2554 to 10fc581 Dec 23, 2016

implement scroll handoff

Loading status checks…

d541621

gterzian force-pushed the gterzian:handoff_scroll_when_end_of_layer_reached branch from c79d4ac to d541621 Dec 23, 2016

gterzian changed the title ~~Handoff scroll when end of layer reached, and new gesture starts~~ Implement scroll handoff Dec 23, 2016

bors-servo merged commit d541621 into servo:master Jan 17, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

servo / webrender

Implement scroll handoff #599

Implement scroll handoff #599

gterzian commented Nov 27, 2016 •

edited

glennw commented Nov 28, 2016

glennw commented Nov 28, 2016

glennw commented Nov 28, 2016

gterzian commented Nov 28, 2016 •

edited

mstange commented Nov 28, 2016

bors-servo commented Nov 28, 2016

glennw commented Nov 28, 2016

gterzian commented Nov 29, 2016 •

edited

gterzian commented Nov 30, 2016 •

edited

glennw commented Nov 30, 2016

gterzian commented Dec 1, 2016

gterzian commented Dec 13, 2016

glennw commented Dec 21, 2016

This comment has been minimized.

This comment has been minimized.

kvark left a comment

gterzian commented Dec 23, 2016

glennw commented Jan 3, 2017

gterzian commented Jan 4, 2017

glennw commented Jan 17, 2017

glennw commented Jan 17, 2017

glennw commented Jan 17, 2017

bors-servo commented Jan 17, 2017

bors-servo commented Jan 17, 2017

bors-servo commented Jan 17, 2017

gterzian commented Jan 18, 2017

servo / webrender

Join GitHub today

Implement scroll handoff #599

Implement scroll handoff #599

Conversation

gterzian commented Nov 27, 2016 • edited

glennw commented Nov 28, 2016

glennw commented Nov 28, 2016

glennw commented Nov 28, 2016

gterzian commented Nov 28, 2016 • edited

mstange commented Nov 28, 2016

bors-servo commented Nov 28, 2016

glennw commented Nov 28, 2016

gterzian commented Nov 29, 2016 • edited

gterzian commented Nov 30, 2016 • edited

glennw commented Nov 30, 2016

gterzian commented Dec 1, 2016

gterzian commented Dec 13, 2016

glennw commented Dec 21, 2016

This comment has been minimized.

glennw Dec 21, 2016

This comment has been minimized.

glennw Dec 21, 2016

kvark left a comment

gterzian commented Dec 23, 2016

glennw commented Jan 3, 2017

gterzian commented Jan 4, 2017

glennw commented Jan 17, 2017

glennw commented Jan 17, 2017

glennw commented Jan 17, 2017

bors-servo commented Jan 17, 2017

bors-servo commented Jan 17, 2017

bors-servo commented Jan 17, 2017

gterzian commented Jan 18, 2017

gterzian commented Nov 27, 2016 •

edited

gterzian commented Nov 28, 2016 •

edited

gterzian commented Nov 29, 2016 •

edited

gterzian commented Nov 30, 2016 •

edited