Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInstanced attributes #615
Instanced attributes #615
Conversation
|
|
|
@kvark Is this still WIP or ready for review? |
|
|
|
Ready for review and landable, but I'm going to convert the rest of the shaders and eliminate the UBO completely.
… On Dec 9, 2016, at 8:44, Glenn Watson ***@***.***> wrote:
@kvark Is this still WIP or ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@kvark OK - would you prefer we land this after review, or wait until the UBO removal is done? |
|
Let me remove the UBOs completely in this PR. Meanwhile, @jamienicol is going to check for the HW extensions support on GLES w.r.t. the instanced attributes. |
|
The PR is ready for review now. |
|
Reviewed 23 of 24 files at r1. webrender/src/device.rs, line 190 at r1 (raw file):
Can we accumulate a variable here? Otherwise it'll be really easy to add an item to the array above and forget to update this value. Comments from Reviewable |
|
@kvark Looks good, just one small issue to address. |
|
@glennw thanks for having a look. The offset is now calculated, and I agree this is better. |
|
@bors-servo r+ |
|
|
|
|
|
|
|
Rebased now. |
|
@bors-servo r+ |
|
|
Instanced attributes Closes #457 Performance-wise, I wasn't able to register a noticeable difference. Tested on https://github.com/servo/servo, full screen after the second page down, on `Mesa DRI Intel(R) HD Graphics 5500 (Broadwell GT2)` with resolution 2560x1440. With the change, I got 4.5 ms mean GPU time in the first test, and 4.3 ms time in the second. Without the change, I got 4.4 ms mean GPU time in the only test. I suppose the difference is not visible since we are far from being VS-bound. Note: this does not replace the optimization of having one large buffer in #456. Instanced attributes will benefit from it in the same way as UBOs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/615) <!-- Reviewable:end -->
|
|
kvark commentedDec 2, 2016
•
edited
Closes #457
Performance-wise, I wasn't able to register a noticeable difference. Tested on https://github.com/servo/servo, full screen after the second page down, on
Mesa DRI Intel(R) HD Graphics 5500 (Broadwell GT2)with resolution 2560x1440.With the change, I got 4.5 ms mean GPU time in the first test, and 4.3 ms time in the second.
Without the change, I got 4.4 ms mean GPU time in the only test.
I suppose the difference is not visible since we are far from being VS-bound.
Note: this does not replace the optimization of having one large buffer in #456. Instanced attributes will benefit from it in the same way as UBOs.
This change is