Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default precision of `sampler2DArray` #627

Merged
merged 1 commit into from Dec 12, 2016
Merged

Fix default precision of `sampler2DArray` #627

merged 1 commit into from Dec 12, 2016

Conversation

@mmatyas
Copy link
Contributor

mmatyas commented Dec 12, 2016 •
edited by larsbergstrom

This fixes the no default precision defined for variable 'sCache' error produced by Servo on Android.

Related: servo/servo#13154

This change is Reviewable
@mmatyas
Fix default precision of `sampler2DArray`
Loading status checks…
660b3fd
@kvark
kvark approved these changes Dec 12, 2016
View changes
Copy link
Member

kvark left a comment

LGTM
@mmatyas mmatyas mentioned this pull request Dec 12, 2016
Closed
@glennw
Copy link
Member

glennw commented Dec 12, 2016

Is GL_FRAGMENT_PRECISION_HIGH defined on non-ES (i.e. desktop implementations)? It might be best to wrap it with GL_ES defined too?
@kvark
Copy link
Member

kvark commented Dec 12, 2016 •
edited

@glennw FYI, I don't think it matters:

Precision qualifiers in GLSL are supported for compatibility with OpenGL ES 2.0. They use the same syntax as ES 2.0's qualifiers, but they have no functional effects.
@glennw
Copy link
Member

glennw commented Dec 12, 2016

@kvark OK, that should be fine then.
@glennw
Copy link
Member

glennw commented Dec 12, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2016

📌 Commit 660b3fd has been approved by glennw
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2016

⌛ Testing commit 660b3fd with merge b7b211b...
bors-servo added a commit that referenced this pull request Dec 12, 2016
@bors-servo
Auto merge of #627 - mmatyas:shader_default_precision_error, r=glennw
Loading status checks…
b7b211b 
Fix default precision of `sampler2DArray`

This fixes the `no default precision defined for variable 'sCache'` error produced by Servo on Android.

Related: servo/servo#13154

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/627)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 12, 2016

☀️ Test successful - status-travis
@bors-servo bors-servo merged commit 660b3fd into servo:master Dec 12, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@kvark
Copy link
Member

kvark commented Dec 13, 2016

It appears to be failing now on Windows/AMD:

ERROR: 0:6: error(#228) Type should be float or int

It doesn't like precision qualifier for sampler2DArray
@glennw
Copy link
Member

glennw commented Dec 13, 2016

@kvark OK, let's wrap it in GL_ES then?
@kvark
Copy link
Member

kvark commented Dec 13, 2016

@glennw yes, your intuition was correct, let's wrap it up
@mmatyas mmatyas mentioned this pull request Dec 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@mmatyas @glennw @kvark @bors-servo
You can’t perform that action at this time.