Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix for the non-owned clipping region under the collapsed stack model #694
Conversation
…del.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 10, 2017
Fix for the non-owned clipping region under the collapsed stack model Test case YAML for wrench (provided by @jrmuizel ): [mask.zip](https://github.com/servo/webrender/files/694976/mask.zip) Makes the top clip instance optional for the `new_mask` task constructor. Piggy-backs on `layer_masks_tasks` for the primitives not owning any clips but inheriting some under the collapsed stack model. r? @glennw <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/694) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedJan 10, 2017
•
edited by larsbergstrom
Test case YAML for wrench (provided by @jrmuizel ): mask.zip
Makes the top clip instance optional for the
new_masktask constructor.Piggy-backs on
layer_masks_tasksfor the primitives not owning any clips but inheriting some under the collapsed stack model.r? @glennw
This change is