Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for updating texture cache, and support canvas animation. #72
+154
−51
Conversation
NOTE: The logic to detect if old batches can be reused will need to take into account if a new image has been received. This doesn't currently matter if the image is the same size/format, since the same texture cache slot is used - however, when different size/format is supported, the batch will need to be invalidated too!
glennw
added a commit
that referenced
this pull request
Nov 2, 2015
Add support for updating texture cache, and support canvas animation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
glennw commentedNov 2, 2015
NOTE: The logic to detect if old batches can be reused will need to
take into account if a new image has been received. This doesn't currently
matter if the image is the same size/format, since the same texture cache
slot is used - however, when different size/format is supported, the batch
will need to be invalidated too!