Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProperly blur box shadows, and correctly calculate the new texture coordinates when clipping rectangles. #74
Conversation
coordinates when clipping rectangles. We use a closed form formula for computing Gaussian blurs of a box shadow. Assuming the blur radius is less than the size of the box, the maximum per-pixel error from this formula has been observed to be less than 3% in practice. It avoids the creation of intermediate textures.
glennw
added a commit
that referenced
this pull request
Nov 5, 2015
Properly blur box shadows, and correctly calculate the new texture coordinates when clipping rectangles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 5, 2015
We use a closed form formula for computing Gaussian blurs of a box
shadow. Assuming the blur radius is less than the size of the box, the
maximum per-pixel error from this formula has been observed to be less
than 3% in practice. It avoids the creation of intermediate textures.