Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReuse batches across paints on a per-node basis. #75
Conversation
This didn't really improve performance from what I saw, but it's a cleaner and more general optimization than the one we had previously, which only reused batches if the entire display list didn't change. In any case, it's a precursor to more aggressive optimizations we could do to reuse portions of batches within AABB tree nodes.
|
Does this guarantee that the display item keys remain the same (the order of these is used to ensure correct paint order)? |
|
This seems too out of date now, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 6, 2015
This didn't really improve performance from what I saw, but it's a
cleaner and more general optimization than the one we had previously,
which only reused batches if the entire display list didn't change. In
any case, it's a precursor to more aggressive optimizations we could do
to reuse portions of batches within AABB tree nodes.