Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify clip rects and clip regions into a single "combined clip region" structure, and clip inset box shadows to rounded rectangle corners. #76
Conversation
I accidentally submitted an old, broken version of the box shadow shader in the previous patch.
structure, and clip inset box shadows to rounded rectangle corners. This necessitated changing box shadows to RGBA, because we can't use two mask textures. An alternate solution for the future would be have a "mask combiner" path that can combine two masks as a raster op, but this is more complex.
glennw
added a commit
that referenced
this pull request
Nov 8, 2015
Unify clip rects and clip regions into a single "combined clip region" structure, and clip inset box shadows to rounded rectangle corners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 7, 2015
This necessitated changing box shadows to RGBA, because we can't use two
mask textures. An alternate solution for the future would be have a
"mask combiner" path that can combine two masks as a raster op, but this
is more complex.
This also fixes the box shadow fragment shader, as noted in the first commit.