Move binary recordings to a single file instead of a directory #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvuk
force-pushed
the
single-file-recording
branch
from
f34a77c to
8d63c65
Compare
Member
|
I read through it, looks great! |
Member
|
Looks like there is still a compile error on CI? |
Contributor
Author
|
Yes - working on it, I think I pushed the wrong branch. Checking on laptop
shortly
|
vvuk
force-pushed
the
single-file-recording
branch
from
5226c10 to
13d6aba
Compare
Member
|
@kvark OK, The CI errors are resolved, if you have time to re-look at this. |
Contributor
|
☔ The latest upstream changes (presumably #775) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Thanks @vvuk, the code is great, and the changes are much welcome! |
Member
|
@bors-servo delegate+ |
Contributor
|
✌️ @vvuk can now approve this pull request |
vvuk
force-pushed
the
single-file-recording
branch
from
13d6aba to
1df751b
Compare
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit 1df751b has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 30, 2017
Move binary recordings to a single file instead of a directory No reason to use separate files. In the future, we could even gzip as we stream out (on a different thread maybe). This also cleans up the recording code to just have a single unified path instead of separate detour stuff. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/765) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
This was referenced Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to use separate files. In the future, we could even gzip as we stream out (on a different thread maybe). This also cleans up the recording code to just have a single unified path instead of separate detour stuff.
This change is