Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove binary recordings to a single file instead of a directory #765
Conversation
|
I read through it, looks great! |
|
Looks like there is still a compile error on CI? |
|
Yes - working on it, I think I pushed the wrong branch. Checking on laptop
shortly
|
|
@kvark OK, The CI errors are resolved, if you have time to re-look at this. |
|
|
|
Thanks @vvuk, the code is great, and the changes are much welcome! |
|
@bors-servo delegate+ |
|
|
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 30, 2017
Move binary recordings to a single file instead of a directory No reason to use separate files. In the future, we could even gzip as we stream out (on a different thread maybe). This also cleans up the recording code to just have a single unified path instead of separate detour stuff. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/765) <!-- Reviewable:end -->
|
|
This was referenced Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vvuk commentedJan 23, 2017
•
edited by larsbergstrom
No reason to use separate files. In the future, we could even gzip as we stream out (on a different thread maybe). This also cleans up the recording code to just have a single unified path instead of separate detour stuff.
This change is