Join GitHub today
revise gradients to use a lookup texture (supporting large amounts of… #792
Reviewed 20 of 20 files at r1.
If we do have a BGRA color (see comments below), this should probably be a different type, to make use of the type system.
Is there a specific reason to introduce the BGRA code? It seems to introduce some additional complexity (esp. if PackedColor can be either format).
I don't think there's any need to implement this - it can be derived if required with #[derive(Clone)]
Let's add a TODO comment here to calculate if the primitive is actually opaque (so that it can be renderer in the opaque pass).
We should add a comment here explaining why it's 2*
Comments from Reviewable