Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd initial tidy support #794
Merged
+41
−12
Conversation
|
Sweeeet |
| # gradually. | ||
| directories = [ | ||
| # Generated and upstream code combined with our own. Could use cleanup | ||
| "./target", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mrobinson
Jan 29, 2017
Author
Member
The comment is indeed a little unclear, but this is a list of directories excluded from the tidy. We will gradually remove entries.
|
@bors-servo r+ |
|
|
|
|
|
|
|
@mrobinson Needs a rebase. Also, the removal of replay/ dir has landed now - so we can remove that from the config file. |
Currently many directories are ignored, but we can add them as we tidy things up
|
@glennw Thanks for the review. |
|
@bors-servo r=glennw |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 30, 2017
Add initial tidy support Currently many directories are ignored, but we can add them as we tidy things up <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/794) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mrobinson commentedJan 27, 2017
•
edited by larsbergstrom
Currently many directories are ignored, but we can add them as we tidy
things up
This change is