Add initial tidy support #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Jan 27, 2017
| # gradually. | ||
| directories = [ | ||
| # Generated and upstream code combined with our own. Could use cleanup | ||
| "./target", |
Member
There was a problem hiding this comment.
why do we need to tidy up the generated code?
Member
Author
There was a problem hiding this comment.
The comment is indeed a little unclear, but this is a list of directories excluded from the tidy. We will gradually remove entries.
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit b670e74 has been approved by |
Contributor
|
🔒 Merge conflict |
Contributor
|
☔ The latest upstream changes (presumably #765) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@mrobinson Needs a rebase. Also, the removal of replay/ dir has landed now - so we can remove that from the config file. |
Currently many directories are ignored, but we can add them as we tidy things up
Member
Author
|
@glennw Thanks for the review. |
Member
Author
|
@bors-servo r=glennw |
Contributor
|
📌 Commit 4c389dc has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Jan 30, 2017
Add initial tidy support Currently many directories are ignored, but we can add them as we tidy things up <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/794) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many directories are ignored, but we can add them as we tidy
things up
This change is